From 0bf8e320625afe25af55ea0ea4ae5fcfc30dda8c Mon Sep 17 00:00:00 2001
From: HikariKnight <2557889+HikariKnight@users.noreply.github.com>
Date: Sat, 12 Mar 2022 14:14:56 +0100
Subject: [PATCH] Cleanup

---
 lib/get_GPU_ROM.sh | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/lib/get_GPU_ROM.sh b/lib/get_GPU_ROM.sh
index f4e6672..4869daa 100755
--- a/lib/get_GPU_ROM.sh
+++ b/lib/get_GPU_ROM.sh
@@ -6,7 +6,7 @@ function get_GPU_ROM () {
     source "$SCRIPTDIR/lib/paths.sh"
 
     VBIOS_PATH=$(find /sys/devices -name rom | grep "$1")
-    printf "We will now attempt to dump the vbios of your selected GPU.
+    echo "We will now attempt to dump the vbios of your selected GPU.
 Passing a VBIOS rom to the card used for passthrough is required for some cards, but not all.
 Some cards also requires you to patch your VBIOS romfile, check online if this is neccessary for your card.
 The VBIOS will be read from $VBIOS_PATH
@@ -17,15 +17,17 @@ sudo cat $VBIOS_PATH > $SCRIPTDIR/$QUICKEMU/vfio_card.rom
 echo 0 | sudo tee $VBIOS_PATH
 
 "
-    read -p "Do you want to dump the VBIOS, choosing N will skip this step [y/N]: " YESNO
+    read -r -p "Do you want to dump the VBIOS, choosing N will skip this step [y/N]: " YESNO
     case "${YESNO}" in
     [Yy]*)
         echo 1 | sudo tee "$VBIOS_PATH"
         sudo cat "$VBIOS_PATH" > "$SCRIPTDIR/$QUICKEMU/vfio_card.rom"
         sudo md5sum "$VBIOS_PATH" | cut -d " " -f 1 > "$SCRIPTDIR/$QUICKEMU/vfio_card.rom.md5"
-        local ROM_MD5=$(sudo md5sum "$VBIOS_PATH" | cut -d " " -f 1)
+        local ROM_MD5
+        ROM_MD5=$(sudo md5sum "$VBIOS_PATH" | cut -d " " -f 1)
         echo 0 | sudo tee "$VBIOS_PATH"
-        local ROMFILE_MD5=$(md5sum "$SCRIPTDIR/$QUICKEMU/vfio_card.rom" | cut -d " " -f 1)
+        local ROMFILE_MD5
+        ROMFILE_MD5=$(md5sum "$SCRIPTDIR/$QUICKEMU/vfio_card.rom" | cut -d " " -f 1)
 
         if [ -f "$SCRIPTDIR"/$QUICKEMU/vfio_card.rom ];
         then
@@ -35,14 +37,14 @@ echo 0 | sudo tee $VBIOS_PATH
                 echo "Dumping of VBIOS successful!"
                 echo 'GPU_ROMFILE="vfio_card.rom"' >> "$SCRIPTDIR/$QUICKEMU/qemu-vfio_vars.conf"
 
-                read -p "Press ENTER to continue." ENTER
+                read -r -p "Press ENTER to continue."
             else
                 echo "Checksums does not match!"
                 echo "Dumping of VBIOS failed, skipping romfile"
                 mv "$SCRIPTDIR/$QUICKEMU/vfio_card.rom" "$SCRIPTDIR/$QUICKEMU/vfio_card.rom.fail"
                 echo 'GPU_ROMFILE=""' >> "$SCRIPTDIR/$QUICKEMU/qemu-vfio_vars.conf"
 
-                read -p "Press ENTER to continue." ENTER
+                read -r -p "Press ENTER to continue."
             fi
         else
             echo 'GPU_ROMFILE=""' >> "$SCRIPTDIR/$QUICKEMU/qemu-vfio_vars.conf"
@@ -61,7 +63,7 @@ echo 0 | sudo tee $VBIOS_PATH
 function main () {
     SCRIPTDIR=$(dirname "$(which $0)" | perl -pe "s/\/\.\.\/lib//" | perl -pe "s/\/lib$//")
 
-    get_GPU_ROM $1
+    get_GPU_ROM "$1"
 }
 
-main $1
\ No newline at end of file
+main "$1"
\ No newline at end of file