From 517b0385a2fae0e7185ec213ebafb92dfcadced1 Mon Sep 17 00:00:00 2001
From: HikariKnight <2557889+HikariKnight@users.noreply.github.com>
Date: Sun, 27 Feb 2022 17:58:41 +0100
Subject: [PATCH] verify romfile after dumping

---
 lib/get_GPU_ROM.sh | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
 mode change 100644 => 100755 lib/get_GPU_ROM.sh

diff --git a/lib/get_GPU_ROM.sh b/lib/get_GPU_ROM.sh
old mode 100644
new mode 100755
index 162fcef..21830dc
--- a/lib/get_GPU_ROM.sh
+++ b/lib/get_GPU_ROM.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 function get_GPU_ROM () {
     clear
     # Get the config paths
@@ -11,18 +13,19 @@ The VBIOS will be read from $VBIOS_PATH
 This process will require the use of sudo and will run the following commands:
 
 echo 1 | sudo tee $VBIOS_PATH
-cat $VBIOS_PATH > $SCRIPTDIR/$QUICKEMU/vfio_card.rom
+sudo cat $VBIOS_PATH > $SCRIPTDIR/$QUICKEMU/vfio_card.rom
 echo 0 | sudo tee $VBIOS_PATH
 
 "
-    read "Do you want to dump the VBIOS, choosing N will skip this step [y/N]: " YESNO
+    read -p "Do you want to dump the VBIOS, choosing N will skip this step [y/N]: " YESNO
     case "${YESNO}" in
     [Yy]*)
         echo 1 | sudo tee $VBIOS_PATH
-        cat $VBIOS_PATH > "$SCRIPTDIR/$QUICKEMU/vfio_card.rom"
-        ROM_MD5=$(md5sum $VBIOS_PATH)
+        sudo cat $VBIOS_PATH > "$SCRIPTDIR/$QUICKEMU/vfio_card.rom"
+        sudo md5sum $VBIOS_PATH | cut -d " " -f 1 > "$SCRIPTDIR/$QUICKEMU/vfio_card.rom.md5"
+        ROM_MD5=$(sudo md5sum $VBIOS_PATH | cut -d " " -f 1)
         echo 0 | sudo tee $VBIOS_PATH
-        ROMFILE_MD5=$(md5sum "$SCRIPTDIR/$QUICKEMU/vfio_card.rom")
+        ROMFILE_MD5=$(md5sum "$SCRIPTDIR/$QUICKEMU/vfio_card.rom" | cut -d " " -f 1)
 
         if [ -f $SCRIPTDIR/$QUICKEMU/vfio_card.rom ];
         then
@@ -32,14 +35,14 @@ echo 0 | sudo tee $VBIOS_PATH
                 echo "Dumping of VBIOS successful!"
                 echo 'GPU_ROMFILE="vfio_card.rom"' >> "$SCRIPTDIR/$QUICKEMU/qemu-vfio_vars.conf"
 
-                read "Press ENTER to continue." ENTER
+                read -p "Press ENTER to continue." ENTER
             else
                 echo "Checksums does not match!"
                 echo "Dumping of VBIOS failed, skipping romfile"
                 mv "$SCRIPTDIR/$QUICKEMU/vfio_card.rom" "$SCRIPTDIR/$QUICKEMU/vfio_card.rom.fail"
                 echo 'GPU_ROMFILE=""' >> "$SCRIPTDIR/$QUICKEMU/qemu-vfio_vars.conf"
 
-                read "Press ENTER to continue." ENTER
+                read -p "Press ENTER to continue." ENTER
             fi
         else
             echo 'GPU_ROMFILE=""' >> "$SCRIPTDIR/$QUICKEMU/qemu-vfio_vars.conf"